moshyfawn.dev
forked from
tangled.org/core
Monorepo for Tangled
spindle/db: prevent status events from overwriting terminal states
Fixes a race condition where a cancelled pipeline's status could be overwritten by a late-arriving failed status event from a container that was still winding down.
Signed-off-by: moshyfawn <email@moshyfawn.dev>
+7
+7
spindle/db/events.go
+7
spindle/db/events.go
···
77
77
exitCode *int64,
78
78
n *notifier.Notifier,
79
79
) error {
80
+
// don't overwrite a terminal status
81
+
if current, err := d.GetStatus(workflowId); err == nil {
82
+
if models.StatusKind(current.Status).IsFinish() {
83
+
return nil
84
+
}
85
+
}
86
+
80
87
now := time.Now()
81
88
pipelineAtUri := workflowId.PipelineId.AtUri()
82
89
s := tangled.PipelineStatus{