Your one-stop-cake-shop for everything Freshly Baked has to offer

refactor(pm/copyparty): remove useless header-hide #121

closed opened by a.starrysky.fyi targeting main from private/minion/push-oqywmpqruopz

In the copyparty code, we previously hid a header before overriding it.

Hiding a header hides it from the client when the server sends it. There's no point to it here. It isn't actively harmful, since as we set the header after anyway, but it's also not required and could be confusing.

Labels

None yet.

requested-reviewers

None yet.

approved

None yet.

tested-working

None yet.

rejected

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:uuyqs6y3pwtbteet4swt5i5y/sh.tangled.repo.pull/3mavdhtp6xr22
-1
Diff #1
-1
packetmix/systems/teal/copyparty.nix
··· 177 177 proxyWebsockets = true; 178 178 179 179 extraConfig = '' 180 - proxy_hide_header X-Webauth-Login; 181 180 proxy_set_header X-Webauth-Login $preferred_username; 182 181 183 182 proxy_intercept_errors on;

History

4 rounds 1 comment
sign up or login to add to the discussion
1 commit
expand
refactor(pm/copyparty): remove useless header-hide
expand 1 comment

manually merged due to tangled error

closed without merging
1 commit
expand
refactor(pm/copyparty): remove useless header-hide
expand 0 comments
1 commit
expand
refactor(pm/copyparty): remove useless header-hide
expand 0 comments
1 commit
expand
refactor(pm/copyparty): remove useless header-hide
expand 0 comments