Your one-stop-cake-shop for everything Freshly Baked has to offer

ci: fetch dependencies before evaluate #128

merged opened by a.starrysky.fyi targeting main from private/minion/push-mlmuvqqtptlt

Due to what I suspect must be either an npins or a lix bug, we get this error when evaluating our configuration on new machines:

โ€ฆ while fetching the input 'git+https://gerrit.wikimedia.org/r/mediawiki/extensions/AdvancedSearch?rev=398c9fa782843d8b3aeaa5ebb1c1b3db35c3382f'

error: Cannot find Git revision '398c9fa782843d8b3aeaa5ebb1c1b3db35c3382f' in ref 'refs/heads/master' of repository 'https://gerrit.wikimedia.org/r/mediawiki/extensions/AdvancedSearch'! Please make sure that the rev exists on the ref you've specified or add allRefs = true; to fetchGit.

Now, this is what I'd expect - because we're not meant to be fetching master of this extension - we're meant to be fetching a branch! By using npins to prefetch all dependencies, we get around this.

Due to a nilla bug, fetching dependencies is required for evaluation anyway - so this isn't too much more of an issue than it would already have been...

Labels

None yet.

requested-reviewers

None yet.

approved

None yet.

tested-working

None yet.

rejected

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:uuyqs6y3pwtbteet4swt5i5y/sh.tangled.repo.pull/3mbbxryg4sg22
+7 -4
Interdiff #2 โ†’ #3
+7 -4
packetmix/npins/default.nix
··· 94 94 fetchSubmodules = submodules; 95 95 hash = narHash; 96 96 } // (if branch == null then {} else { 97 - ref = "refs/heads/${branch}"; 98 - })); 97 + ref = "refs/heads/${branch}"; 98 + })); 99 99 }; 100 100 101 101 # Dispatch to the correct code path based on the type ··· 127 127 repository, 128 128 revision, 129 129 url ? null, 130 + branch ? null, 130 131 submodules, 131 132 hash, 132 133 ... ··· 162 163 "${if matched == null then "source" else builtins.head matched}${appendShort}"; 163 164 name = urlToName url revision; 164 165 in 165 - fetchGit { 166 + fetchGit ({ 166 167 rev = revision; 167 168 narHash = hash; 168 169 169 170 inherit name submodules url; 170 - }; 171 + } // (if branch == null then {} else { 172 + ref = "refs/heads/${branch}"; 173 + })); 171 174 172 175 mkPyPiSource = 173 176 { fetchurl, ... }:

History

15 rounds 0 comments
sign up or login to add to the discussion
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
1/5 failed, 4/5 success
expand
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
expand 0 comments
1 commit
expand
fix(npins): fetch dependencies from correct ref
expand 0 comments
1 commit
expand
ci: fetch dependencies before evaluate
expand 0 comments
1 commit
expand
ci: fetch dependencies before evaluate
expand 0 comments