Fix enter-to-select #1

merged opened by

jolheiser.com 4 months ago targeting main

Removing the click event handler broke enter-to-select. This patch just dispatches the pointerup event instead.

Labels

None yet.

assignee

jakelazaroff.com

Participants 3

AT URI

at://did:plc:35kdk2ntcs626zs6cm62i7ih/sh.tangled.repo.pull/3m63nyysm4422

+1 -1

1 changed file

Diff round #0

expand all

actor-typeahead.js

+1 -1

actor-typeahead.js

··· 214 214 215 215 case "Enter": 216 216 evt.preventDefault(); 217 - this.#shadow.querySelectorAll("button")[this.#index]?.click(); 217 + this.#shadow.querySelectorAll("button")[this.#index]?.dispatchEvent(new PointerEvent("pointerup", { bubbles: true })); 218 218 break; 219 219 } 220 220 }

History

1 round 2 comments

jolheiser.com submitted #0 4mo

1 commit

expand

8e199bb2

fix enter button to select

expand 2 comments

oppi.li 4mo

just came here to open an issue about the same, thanks for opening a PR!

jakelazaroff.com 4mo

thank you so much! sorry about that

pull request successfully merged