feat: Config format tweak with stronger type validation #8

Fixes the config format to require values to be strings, so to avoid problems with toml Value not being able to accommodate certain types, but then adds parsing according to the declared type to ensure the values are valid before being formatted into constants.

+14 -1

2 changed files

Interdiff #0 → #1

expand all

.tangled

workflows

test.yml

sachy-config

src

lib.rs

.tangled/workflows/test.yml

This file has not been changed.

+14 -1

sachy-config/src/lib.rs

··· 91 91 "i128" => validate_kind_to_string::<i128>(name, kind, value)?, 92 92 "f32" => validate_kind_to_string::<f32>(name, kind, value)?, 93 93 "f64" => validate_kind_to_string::<f64>(name, kind, value)?, 94 - "&str" => bail!("{} is a string, use [statics] for these", kind), 94 + "&str" => bail!("{} is a {}, use [statics] for these", name, kind), 95 95 _ => bail!("Unsupported type: {}", kind), 96 96 }; 97 97 ··· 155 155 assert!(error_chain.next().is_none()); 156 156 157 157 Ok(()) 158 + } 159 + 160 + #[test] 161 + fn it_disallows_string_constants() { 162 + let input = r#"[constants] 163 + FIRST = { type = "&str", value = "42" } 164 + "#; 165 + 166 + let expected = "FIRST is a &str, use [statics] for these"; 167 + 168 + let output = parse_config(input).expect_err("Output somehow successfully parsed"); 169 + 170 + assert_eq!(output.to_string(), expected); 158 171 } 159 172 160 173 #[test]