Monorepo for Tangled tangled.org

appview/newComment: add submit shortcut #1106

merged opened by marco.tngl.sh targeting master from marco.tngl.sh/core: push-lxxussryqomn
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:uvlgxr6xf446eugiky6s3swz/sh.tangled.repo.pull/3mg3ovr453p22
+2 -1
Interdiff #0 #1
+2 -1
appview/pages/templates/repo/issues/fragments/newComment.html
··· 4 4 id="comment-form" 5 5 hx-post="/{{ .RepoInfo.FullName }}/issues/{{ .Issue.IssueId }}/comment" 6 6 hx-trigger="submit, keydown[commentButtonEnabled() && (ctrlKey || metaKey) && key=='Enter'] from:#comment-textarea" 7 + hx-indicator="#comment-button" 8 + hx-disabled-elt="#comment-form button" 7 9 hx-on::after-request="if(event.detail.successful) this.reset()" 8 10 > 9 11 <div class="bg-white dark:bg-gray-800 rounded drop-shadow-sm py-4 px-4 relative w-full"> ··· 26 28 <button 27 29 id="comment-button" 28 30 type="submit" 29 - hx-disabled-elt="#comment-button" 30 31 class="btn-create p-2 flex items-center gap-2 no-underline hover:no-underline group" 31 32 disabled 32 33 >

History

2 rounds 2 comments
sign up or login to add to the discussion
1 commit
expand
appview/newComment: add submit shortcut
expand 0 comments
pull request successfully merged
1 commit
expand
appview/newComment: add submit shortcut
expand 2 comments

there are a few minor regressions with this one:

  • the comment button is no longer disabled when the request is inflight
  • the spinners are not visible anymore

Sorry about that and thanks for checking! I've changed it so that all buttons in the form are disabled when the request is inflight. I figured it makes more sense this way, otherwise one would be able to double submit through the "close with comment" button.