tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: add basic issue indexer (wip) #494

merged opened by boltless.me targeting master from boltless.me/core: feat/search
  • Heavily inspired by gitea
  • add GetAllIssues which only receives a paginator and gathers all issues ignoring repoAt field

Signed-off-by: Seongmin Lee boltlessengineer@proton.me

STACK 13
#711 appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
1
#6
#710 appview: add pull_reopen event
0
#6
#709 appview/pulls: add search endpoint
0
#6
#708 appview/indexer: add pulls indexer
0
#6
#707 appview: add issue_reopen event
0
#6
#706 appview/indexer: put bleve index dir under indexes/ dir
0
#6
#693 appview/notify: pass logger with mergedLogger
2
#9
#695 appview/indexer: handle NewIssueClosed
1
#9
#694 appview/notify: add DeleteIssue event
1
#9
#496 appview: add issue search endpoint
5
#13
#495 wip: add indexer mappings
1
#14
#494 appview: add basic issue indexer (wip)
2
#14
#685 go.mod: add bleve as a dependency
1
#10
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3lwecnvoz4z22
+22 -22
Interdiff #11 → #12
.gitignore

This file has not been changed.

appview/indexer/base36/base36.go

This file has not been changed.

appview/indexer/bleve/batch.go

This file has not been changed.

appview/indexer/bleve/query.go

This file has not been changed.

appview/indexer/indexer.go

This file has not been changed.

appview/indexer/issues/indexer.go

This file has not been changed.

appview/indexer/notifier.go

This file has not been changed.

appview/issues/issues.go

This patch was likely rebased, as context lines do not match.

appview/models/search.go

This file has not been changed.

appview/pages/pages.go

This patch was likely rebased, as context lines do not match.

+22 -22
appview/pagination/page.go
··· 30 30 } 31 31 } 32 32 33 - func IterateAll[T any]( 34 - fetch func(page Page) ([]T, error), 35 - handle func(items []T) error, 36 - ) error { 37 - page := FirstPage() 38 - for { 39 - items, err := fetch(page) 40 - if err != nil { 41 - return err 42 - } 43 33 44 - err = handle(items) 45 - if err != nil { 46 - return err 47 - } 48 - if len(items) < page.Limit { 49 - break 50 - } 51 - page = page.Next() 52 - } 53 - return nil 54 - } 55 34 56 35 57 36 ··· 70 49 71 50 72 51 52 + Limit: p.Limit, 53 + } 54 + } 73 55 56 + func IterateAll[T any]( 57 + fetch func(page Page) ([]T, error), 58 + handle func(items []T) error, 59 + ) error { 60 + page := FirstPage() 61 + for { 62 + items, err := fetch(page) 63 + if err != nil { 64 + return err 65 + } 74 66 75 - Limit: p.Limit, 67 + err = handle(items) 68 + if err != nil { 69 + return err 70 + } 71 + if len(items) < page.Limit { 72 + break 73 + } 74 + page = page.Next() 76 75 } 76 + return nil 77 77 }
appview/state/router.go

This file has not been changed.

appview/state/state.go

This file has not been changed.

History

15 rounds 2 comments
sign up or login to add to the discussion
boltless.me submitted #14
diff interdiff
1 commit
expand
bb301662
appview: add basic issue indexer
expand 0 comments
pull request successfully merged
boltless.me submitted #13
diff interdiff
1 commit
expand
bb301662
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #12
diff
1 commit
expand
47b55ade
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #11
diff interdiff
1 commit
expand
b335f72a
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #10
diff interdiff
1 commit
expand
429a2f09
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #9
diff interdiff
1 commit
expand
429a2f09
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #8
diff interdiff
1 commit
expand
429a2f09
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
3e70c814
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
3e70c814
appview: add basic issue indexer
expand 1 comment
oppi.li

this changeset largely lgtm!

boltless.me submitted #5
diff interdiff
1 commit
expand
b9a6ec9d
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
66f42aa9
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
e1d4d340
appview: add basic issue indexer
expand 1 comment
oppi.li
  • this is an N+1 query, because we first get all issues and then make one query for each issue. understandably this only needs to happen when populating the indices but we could improve this by just making one query
  • we can use a pagination free API for getting issues with comments while populating indexer
  • more of a note to self: search index should also handle issue deletions
boltless.me submitted #2
diff interdiff
1 commit
expand
c83d9601
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
af090ec1
appview: add basic issue indexer
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
31b2eff1
appview: add basic issue indexer (wip)
expand 0 comments