appview/languages: fix logic bug in updating language breakdowns #625

merged opened by

oppi.li 5 months ago targeting master from push-zomkuzmzokvl

Signed-off-by: oppiliappan me@oppi.li

Labels

None yet.

assignee

None yet.

Participants 1

AT URI

at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.pull/3m23negh5zz22

+2 -5

3 changed files

Interdiff #1 → #2

expand all

appview

language.go

repo

index.go

state

knotstream.go

appview/db/language.go

This file has not been changed.

appview/repo/index.go

This file has not been changed.

+2 -5

appview/state/knotstream.go

··· 181 181 // update appview's cache 182 182 err = db.UpdateRepoLanguages(tx, repo.RepoAt(), ref.Short(), langs) 183 183 if err != nil { 184 + fmt.Printf("failed; %s\n", err) 184 185 // non-fatal 185 186 } 186 187 187 - err = tx.Commit() 188 - if err != nil { 189 - return err 190 - } 191 - return db.InsertRepoLanguages(d, langs) 188 + return tx.Commit() 192 189 } 193 190 194 191 func ingestPipeline(d *db.DB, source ec.Source, msg ec.Message) error {