tangled.org
automatically adds a newline to patches that are missing one.
Signed-off-by: oppiliappan me@oppi.li
appview/pulls/pulls.go
appview/pulls/pulls.go
This file has not been changed.
appview/state/router.go
appview/state/router.go
This file has not been changed.
appview/validator/patch.go
appview/validator/patch.go
This file has not been changed.
knotserver/xrpc/merge_check.go
knotserver/xrpc/merge_check.go
This file has not been changed.
patchutil/patchutil.go
patchutil/patchutil.go
This file has not been changed.
+2
-2
patchutil/patchutil_test.go
+2
-2
patchutil/patchutil_test.go
···
106
106
just some
107
107
random text
108
108
that isn't a patch`,
109
-
expected: EmptyPatchError,
109
+
expected: GenericPatchError,
110
110
},
111
111
}
112
112
113
113
for _, tt := range tests {
114
114
t.Run(tt.name, func(t *testing.T) {
115
115
result := IsPatchValid(tt.patch)
116
-
if errors.Is(result, tt.expected) {
116
+
if !errors.Is(result, tt.expected) {
117
117
t.Errorf("IsPatchValid() = %v, want %v", result, tt.expected)
118
118
}
119
119
})
History
2 rounds
0 comments
1 commit
expand
collapse
appview: improve patch validation
automatically adds a newline to patches that are missing one.
3/3 success
expand
collapse
expand 0 comments
pull request successfully merged
1 commit
expand
collapse
appview: improve patch validation
automatically adds a newline to patches that are missing one.
Signed-off-by: oppiliappan <me@oppi.li>