tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/oauth: support custom PLC directory #704

closed opened by boltless.me targeting master from sandboxed-atmosphere
  • inherit idResolver's PLC directory for oauth
  • override Client.Transport to support PDS served in localhost

Signed-off-by: Seongmin Lee git@boltless.me

STACK 6
#768 local-infra: local, sandboxed atmosphere infra
3/3
1
#0
#701 nix/vm: make vm more configurable
3/3
0
#8
#700 nix: knot: pass config to knot guard
3/3
0
#8
#699 nix: add plcUrl options for services.{knot,spindle}
3/3
0
#8
#698 Revert "Revert "*/config: add PLC URL config option""
3/3
0
#8
#704 appview/oauth: support custom PLC directory
3/3
0
#8
ABANDONED PULLS 1
#718 local-infra: support https scheme for knot
0
#0
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3sa6t262s22
+4 -4
Interdiff #7 → #8
+4 -4
appview/oauth/oauth.go
··· 60 60 61 61 clientApp := oauth.NewClientApp(&oauthConfig, authStore) 62 62 clientApp.Dir = res.Directory() 63 - // allow non-public transports in dev mode 64 - if config.Core.Dev { 65 - clientApp.Resolver.Client.Transport = http.DefaultTransport 66 - } 67 63 68 64 return &OAuth{ 69 65 ClientApp: clientApp, ··· 78 74 79 75 clientApp := oauth.NewClientApp(&oauthConfig, authStore) 80 76 clientApp.Dir = res.Directory() 77 + // allow non-public transports in dev mode 78 + if config.Core.Dev { 79 + clientApp.Resolver.Client.Transport = http.DefaultTransport 80 + } 81 81 82 82 clientName := config.Core.AppviewName 83 83
appview/state/login.go

This file has not been changed.

History

9 rounds 0 comments
sign up or login to add to the discussion
boltless.me submitted #8
diff
1 commit
expand
50b50114
appview/oauth: support local PDS
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
closed without merging
boltless.me submitted #7
diff interdiff
1 commit
expand
1ea4e71e
appview/oauth: support local PDS
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
d0fa16e0
appview/oauth: support local PDS
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
d0fa16e0
appview/oauth: support local PDS
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
5145def5
appview/oauth: support custom PLC directory
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
084c929e
appview/oauth: support custom PLC directory
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
912c2a79
appview/oauth: support custom PLC directory
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
912c2a79
appview/oauth: support custom PLC directory
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
1ea0ca9c
appview/oauth: support custom PLC directory
expand 0 comments