tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState #711

merged opened by boltless.me targeting master from boltless.me/core: feat/search

same to NewIssueState, we can determine the detailed event type from latest pull state

Signed-off-by: Seongmin Lee git@boltless.me

STACK 13
#711 appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
1
#6
#710 appview: add pull_reopen event
0
#6
#709 appview/pulls: add search endpoint
0
#6
#708 appview/indexer: add pulls indexer
0
#6
#707 appview: add issue_reopen event
0
#6
#706 appview/indexer: put bleve index dir under indexes/ dir
0
#6
#693 appview/notify: pass logger with mergedLogger
2
#9
#695 appview/indexer: handle NewIssueClosed
1
#9
#694 appview/notify: add DeleteIssue event
1
#9
#496 appview: add issue search endpoint
5
#13
#495 wip: add indexer mappings
1
#14
#494 appview: add basic issue indexer (wip)
2
#14
#685 go.mod: add bleve as a dependency
1
#10
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3umbnrwph22
+3 -3
Interdiff #0 → #1
appview/indexer/notifier.go

This file has not been changed.

appview/notify/db/db.go

This file has not been changed.

appview/notify/merged_notifier.go

This file has not been changed.

appview/notify/notifier.go

This file has not been changed.

appview/notify/posthog/notifier.go

This file has not been changed.

+3 -3
appview/pulls/pulls.go
··· 2216 2216 2217 2217 // notify about the pull merge 2218 2218 for _, p := range pullsToMerge { 2219 - s.notifier.NewPullMerged(r.Context(), p) 2219 + s.notifier.NewPullState(r.Context(), p) 2220 2220 } 2221 2221 2222 2222 s.pages.HxLocation(w, fmt.Sprintf("/@%s/%s/pulls/%d", f.OwnerHandle(), f.Name, pull.PullId)) ··· 2288 2288 } 2289 2289 2290 2290 for _, p := range pullsToClose { 2291 - s.notifier.NewPullClosed(r.Context(), p) 2291 + s.notifier.NewPullState(r.Context(), p) 2292 2292 } 2293 2293 2294 2294 s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId)) ··· 2361 2361 } 2362 2362 2363 2363 for _, p := range pullsToReopen { 2364 - s.notifier.NewPullReopen(r.Context(), p) 2364 + s.notifier.NewPullState(r.Context(), p) 2365 2365 } 2366 2366 2367 2367 s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))

History

7 rounds 1 comment
sign up or login to add to the discussion
boltless.me submitted #6
diff interdiff
1 commit
expand
ed9371e5
appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
expand 1 comment
oppi.li

thanks for your work on adding search, this works great!

pull request successfully merged
boltless.me submitted #5
diff interdiff
1 commit
expand
f372ba7a
appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
8516b173
appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
955f06be
appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
1c4c3d8d
appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
expand 0 comments
boltless.me submitted #1
diff
1 commit
expand
8cda11b9
appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
a69af6b2
appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
expand 0 comments