Monorepo for Tangled tangled.org

Add CORS top level middleware router to knotserver/ #735

merged opened by

nekomimi.pet 4 months ago targeting master from [deleted fork]: master

To make it easier to get information about tangled repos, CORS need to be enabled on repo knots otherwise browsers will throw a fit. This change adds those headers. I think maybe the auth routes could do without them as right now it just gives it to all the routes.

Labels

None yet.

assignee

None yet.

Participants 2

AT URI

at://did:plc:ttdrpj45ibqunmfhdsb4zdwq/sh.tangled.repo.pull/3m4ivlx63dd22

2 changed files

Interdiff #0 → #1

expand all

knotserver

middleware.go

router.go

knotserver/middleware.go

This file has not been changed.

knotserver/router.go

This file has not been changed.

History

3 rounds 4 comments

nekomimi.pet submitted #2 4mo

diff interdiff

2 commits

expand

59a1308e

knotserver: add cors headers as a middleware function

b19de89d

knotserver: have top level router use cors header function

expand 2 comments

nekomimi.pet 4mo

renamed commits

anirudh.fi 4mo

Amazing, merging!

pull request successfully merged

nekomimi.pet submitted #1 4mo

diff

2 commits

expand

83963a3d

knotserver/middleware.go: add cors headers as a middleware function

729f7fce

knotserver/router.go: have top level router use cors header function

expand 2 comments

nekomimi.pet 4mo

resubmitted to sign off on commits

anirudh.fi 4mo

Awesome, this looks great! Tiny nit about the commits: they can simply be knotserver: … (exclude the filename, we only specify nested directories).

nekomimi.pet submitted #0 4mo

diff

2 commits

expand

88684a67

knotserver/middleware.go: add cors headers as a middleware function

396baab5

knotserver/router.go: have top level router use cors header function

expand 0 comments