tangled.org
Signed-off-by: oppiliappan me@oppi.li
+2
-2
appview/repo/archive.go
+2
-2
appview/repo/archive.go
···
9
9
"tangled.org/core/api/tangled"
10
10
xrpcclient "tangled.org/core/appview/xrpcclient"
11
11
12
+
indigoxrpc "github.com/bluesky-social/indigo/xrpc"
12
13
"github.com/go-chi/chi/v5"
13
14
"github.com/go-git/go-git/v5/plumbing"
14
-
indigoxrpc "github.com/bluesky-social/indigo/xrpc"
15
15
)
16
16
17
17
func (rp *Repo) DownloadArchive(w http.ResponseWriter, r *http.Request) {
···
46
46
w.Header().Set("Content-Length", fmt.Sprintf("%d", len(archiveBytes)))
47
47
// Write the archive data directly
48
48
w.Write(archiveBytes)
49
-
}
49
+
}
-1
appview/repo/blob.go
-1
appview/repo/blob.go
-1
appview/repo/branches.go
-1
appview/repo/branches.go
appview/repo/feed.go
appview/repo/feed.go
This file has not been changed.
appview/repo/index.go
appview/repo/index.go
This file has not been changed.
appview/repo/opengraph.go
appview/repo/opengraph.go
This file has not been changed.
appview/repo/repo.go
appview/repo/repo.go
This file has not been changed.
appview/repo/router.go
appview/repo/router.go
This file has not been changed.
appview/repo/settings.go
appview/repo/settings.go
This file has not been changed.
History
3 rounds
5 comments
1 commit
expand
collapse
appview/repo: split up handlers into separate files
Signed-off-by: oppiliappan <me@oppi.li>
3/3 success
expand
collapse
expand 0 comments
pull request successfully merged
1 commit
expand
collapse
appview/repo: split up handlers into separate files
Signed-off-by: oppiliappan <me@oppi.li>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
appview/repo: split up handlers into separate files
Signed-off-by: oppiliappan <me@oppi.li>
1/3 failed, 2/3 timeout
expand
collapse
expand 5 comments
other than that, I'm 100% supportive to this idea.
I'd prefer we didn't. Go file name convention dictates using an underscore only when needed; I believe the the "handler" bit here is implicit.
perhaps that prefix would make sense if and when we introduce the service layer that we spoke about in earlier conversations.
I don't care much about pascelCase, but I wish we name "handler" explicitly. The repo module itself is already quite ambiguous by mixed with non-handler modules like appview/db.
So we can put the handler prefix to either repo module or each files. And for this case, as the commit message says we are splitting handlers into separate files, so putting prefix for individual files make sense.
I prefer prefix rather than suffix because it makes easier to spot non-prefixed files (like routers or util files) from file explorer.
I would like to add
handler_prefix for all of those files. It will make file navigation way easier. Like https://tangled.org/@hailey.at/cocoon/tree/main/server