tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages: fix checkbox name for notifications when mentioned #847

merged opened by octet-stream.net targeting master from octet-stream.net/core: thombles/save-mentions-notification

Before: when you save notifications preferences, "when someone mentions you" always gets deselected as the HTML checkbox is named mentioned but the form processing logic checks for user_mentioned

          <input type="checkbox" name="mentioned" {{if .Preferences.UserMentioned}}checked{{end}}>

UserMentioned:      r.FormValue("user_mentioned") == "on",

After: HTML checkbox is renamed to user_mentioned so preference is saved correctly

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:txurc6ueald5d7462bpvzdby/sh.tangled.repo.pull/3m75p2dnzq222
+1 -1
Diff #0
+1 -1
appview/pages/templates/user/settings/notifications.html
··· 151 151 </div> 152 152 </div> 153 153 <label class="flex items-center gap-2"> 154 - <input type="checkbox" name="mentioned" {{if .Preferences.UserMentioned}}checked{{end}}> 154 + <input type="checkbox" name="user_mentioned" {{if .Preferences.UserMentioned}}checked{{end}}> 155 155 </label> 156 156 </div> 157 157

History

1 round 1 comment
sign up or login to add to the discussion
octet-stream.net submitted #0
1 commit
expand
da6c89fb
appview/pages: fix checkbox name for notifications when mentioned
expand 1 comment
oppi.li

lgtm thanks!

pull request successfully merged