tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: add issue search endpoint #496

merged opened by boltless.me targeting master from boltless.me/core: feat/search
STACK 13
#711 appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
1
#6
#710 appview: add pull_reopen event
0
#6
#709 appview/pulls: add search endpoint
0
#6
#708 appview/indexer: add pulls indexer
0
#6
#707 appview: add issue_reopen event
0
#6
#706 appview/indexer: put bleve index dir under indexes/ dir
0
#6
#693 appview/notify: pass logger with mergedLogger
2
#9
#695 appview/indexer: handle NewIssueClosed
1
#9
#694 appview/notify: add DeleteIssue event
1
#9
#496 appview: add issue search endpoint
5
#13
#495 wip: add indexer mappings
1
#14
#494 appview: add basic issue indexer (wip)
2
#14
#685 go.mod: add bleve as a dependency
1
#10
Labels
enhancement
assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3lwecnvoz5422
+19 -20
Interdiff #3 → #4
+19 -20
appview/db/issues.go
··· 247 247 return GetIssuesPaginated(e, pagination.FirstPage(), filters...) 248 248 } 249 249 250 - func AddIssueComment(e Execer, c models.IssueComment) (int64, error) { 251 - result, err := e.Exec( 252 - `insert into issue_comments ( 253 - 254 - 255 - 256 - 257 - 258 - 259 - 260 - 261 - 262 - 263 - 264 - 265 - 266 - 267 - return &issue, nil 268 - } 269 - 270 250 // GetIssueIDs gets list of all existing issue's IDs 271 251 func GetIssueIDs(e Execer, opts models.IssueSearchOptions) ([]int64, error) { 272 252 var ids []int64 ··· 323 303 return ids, nil 324 304 } 325 305 306 + func AddIssueComment(e Execer, c models.IssueComment) (int64, error) { 307 + result, err := e.Exec( 308 + `insert into issue_comments ( 309 + 310 + 311 + 312 + 313 + 314 + 315 + 316 + 317 + 318 + 319 + 320 + 321 + 322 + 323 + return &issue, nil 324 + } 326 325 327 326 func AddIssueComment(e Execer, c models.IssueComment) (int64, error) { 328 327 result, err := e.Exec(
appview/issues/issues.go

This file has not been changed.

appview/pages/templates/repo/issues/issues.html

This file has not been changed.

History

14 rounds 5 comments
sign up or login to add to the discussion
boltless.me submitted #13
diff interdiff
1 commit
expand
d07fbce2
appview: add issue search endpoint
expand 0 comments
pull request successfully merged
boltless.me submitted #12
diff interdiff
1 commit
expand
17e2a3bb
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #11
diff interdiff
1 commit
expand
804963e6
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #10
diff interdiff
1 commit
expand
3d998c0f
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #9
diff interdiff
1 commit
expand
7549edf4
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #8
diff interdiff
1 commit
expand
1a4bb573
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
1a4bb573
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
36b591d7
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
36b591d7
appview: add issue search endpoint
expand 3 comments
oppi.li

lgtm

oppi.li

do we need the log here? i believe that log message should be changed atleast because indexing does not occur there.

boltless.me

I can change the wording a bit. The intention was to log the list of issue ids gathered from one of two methods (indexer/db)

boltless.me submitted #4
diff
1 commit
expand
2d3f191b
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
34b87183
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
36bbfc8b
appview: add issue search endpoint
expand 1 comment
boltless.me submitted #1
diff interdiff
1 commit
expand
73c72bea
appview: add issue search endpoint
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
54342b94
appview: add issue search endpoint
expand 1 comment
boltless.me

Indexer mappings/tokenization rules have some room to be improved, but this should be enough as a MVP for now.