Monorepo for Tangled tangled.org

appview: add issue search endpoint #496

merged opened by boltless.me targeting master from boltless.me/core: feat/search
Labels
enhancement
assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3lwecnvoz5422
+1 -2
Interdiff #8 #9
appview/db/issues.go

This file has not been changed.

+1 -2
appview/issues/issues.go
··· 813 813 l.Debug("indexed all issues from the db", "ids", ids) 814 814 } 815 815 816 - issues, err := db.GetIssuesPaginated( 816 + issues, err := db.GetIssues( 817 817 rp.db, 818 - page, 819 818 db.FilterIn("id", ids), 820 819 ) 821 820 if err != nil {
appview/pages/templates/repo/issues/issues.html

This file has not been changed.

History

14 rounds 5 comments
sign up or login to add to the discussion
1 commit
expand
appview: add issue search endpoint
expand 0 comments
pull request successfully merged
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 3 comments

do we need the log here? i believe that log message should be changed atleast because indexing does not occur there.

I can change the wording a bit. The intention was to log the list of issue ids gathered from one of two methods (indexer/db)

1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 1 comment
1 commit
expand
appview: add issue search endpoint
expand 0 comments
1 commit
expand
appview: add issue search endpoint
expand 1 comment

Indexer mappings/tokenization rules have some room to be improved, but this should be enough as a MVP for now.