Pyzotero: a Python client for the Zotero API pyzotero.readthedocs.io
zotero

Merge pull request #247 from urschrei/shugel/push-mwqsrpultnvq

Use a constant for the default item limit

authored by urschrei.eurosky.social and committed by

GitHub ed2bc7af a102d761

+8 -6
+1 -1
pyproject.toml
··· 1 1 [project] 2 2 name = "pyzotero" 3 - version = "1.6.15" 3 + version = "1.6.16" 4 4 description = "Python wrapper for the Zotero API" 5 5 readme = "README.md" 6 6 requires-python = ">=3.9"
+2 -1
src/pyzotero/zotero.py
··· 46 46 NOT_MODIFIED = 304 47 47 ONE_HOUR = 3600 48 48 DEFAULT_NUM_ITEMS = 50 49 + DEFAULT_ITEM_LIMIT = 100 49 50 TOO_MANY_REQUESTS = 429 50 51 51 52 ··· 595 596 params["format"] = "atom" 596 597 # TODO: rewrite format=atom, content=json request 597 598 if "limit" not in params or params.get("limit") == 0: 598 - params["limit"] = 100 599 + params["limit"] = DEFAULT_ITEM_LIMIT 599 600 # Need ability to request arbitrary number of results for version 600 601 # response 601 602 # -1 value is hack that works with current version
+4 -3
tests/test_zotero.py
··· 21 21 22 22 try: 23 23 from pyzotero.pyzotero import zotero as z 24 + from pyzotero.pyzotero.zotero import DEFAULT_ITEM_LIMIT 24 25 except ModuleNotFoundError: 25 26 from pyzotero import zotero as z 26 - 27 + from pyzotero.zotero import DEFAULT_ITEM_LIMIT 27 28 from urllib.parse import urlencode 28 29 29 30 ··· 88 89 zot = z.Zotero("myuserID", "user", "myuserkey") 89 90 zot.add_parameters(limit=0, start=7) 90 91 self.assertEqual( 91 - parse_qs("start=7&limit=100&format=json"), 92 + parse_qs(f"start=7&limit={DEFAULT_ITEM_LIMIT}&format=json"), 92 93 parse_qs(urlencode(zot.url_params, doseq=True)), 93 94 ) 94 95 ··· 438 439 zot.add_parameters(start=2) 439 440 # Should get default limit=100 since no limit specified in second call 440 441 self.assertEqual( 441 - parse_qs("start=2&format=json&limit=100"), 442 + parse_qs(f"start=2&format=json&limit={DEFAULT_ITEM_LIMIT}"), 442 443 parse_qs(urlencode(zot.url_params, doseq=True)), 443 444 ) 444 445
+1 -1
uv.lock
··· 753 753 754 754 [[package]] 755 755 name = "pyzotero" 756 - version = "1.6.15" 756 + version = "1.6.16" 757 757 source = { editable = "." } 758 758 dependencies = [ 759 759 { name = "bibtexparser" },